linux-ext4 - Re: [PATCH] libext2fs: don't swap extent-based journal backup on read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091113034519.GA11891@mit.edu>
Date:	Thu, 12 Nov 2009 22:45:19 -0500
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] libext2fs: don't swap extent-based journal backup on
	read

On Tue, Nov 10, 2009 at 02:45:44PM -0600, Eric Sandeen wrote:
> The f_illitable_flexbg test was failing on ppc, because
> e2fsck_move_ext3_journal is doing a direct memcmp of i_block with 
> s_jnl_blocks, and failing.
> 
> This is because we don't swap extent data on read from disk; rather
> we do it when we access the extents.  However, ext2fs_swap_super
> was swapping s_jnl_blocks unconditionally, so these didn't match.
> 
> Looks like we need to treat s_jnl_blocks the same as i_block, and
> swap it on access, not on read.  Except for the last i_size bit...
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Applied to the maint branch, thanks.

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html