linux-ext4 - Re: [PATCH] ext3: journal all modifications in ext3_xattr_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091119144419.GD24836@duck.suse.cz>
Date:	Thu, 19 Nov 2009 15:44:19 +0100
From:	Jan Kara <jack@...e.cz>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext3: journal all modifications in
 ext3_xattr_set_handle

On Mon 16-11-09 16:27:30, Eric Sandeen wrote:
> ext3_xattr_set_handle() was zeroing out an inode outside
> of journaling constraints; this is one of the accesses that
> was causing the crc errors in journal replay as seen in
> kernel.org bugzilla #14354.
> 
> Although ext3 doesn't have the crc issue, modifications
> out of journal control are a Bad Thing.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
> ---
  Thanks. Looks good. Queue up.

								Honza
> 
> diff --git a/fs/ext3/xattr.c b/fs/ext3/xattr.c
> index 545e37c..387d92d 100644
> --- a/fs/ext3/xattr.c
> +++ b/fs/ext3/xattr.c
> @@ -960,6 +960,10 @@ ext3_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index,
> 	if (error)
> 		goto cleanup;
> 
> +	error = ext3_journal_get_write_access(handle, is.iloc.bh);
> +	if (error)
> +		goto cleanup;
> +
> 	if (EXT3_I(inode)->i_state & EXT3_STATE_NEW) {
> 		struct ext3_inode *raw_inode = ext3_raw_inode(&is.iloc);
> 		memset(raw_inode, 0, EXT3_SB(inode->i_sb)->s_inode_size);
> @@ -985,9 +989,6 @@ ext3_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index,
> 		if (flags & XATTR_CREATE)
> 			goto cleanup;
> 	}
> -	error = ext3_journal_get_write_access(handle, is.iloc.bh);
> -	if (error)
> -		goto cleanup;
> 	if (!value) {
> 		if (!is.s.not_found)
> 			error = ext3_xattr_ibody_set(handle, inode, &i, &is);
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html