linux-ext4 - Re: [PATCH] ext3: make "norecovery" an alias for "noload"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091119151233.GE24836@duck.suse.cz>
Date:	Thu, 19 Nov 2009 16:12:33 +0100
From:	Jan Kara <jack@...e.cz>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext3: make "norecovery" an alias for "noload"

On Mon 16-11-09 16:50:49, Eric Sandeen wrote:
> Users on the list recently complained about differences across
> filesystems w.r.t. how to mount without a journal replay.
> 
> In the discussion it was noted that xfs's "norecovery" option is
> perhaps more descriptively accurate than "noload," so let's make
> that an alias for ext3.
> 
> Also show this status in /proc/mounts
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
  OK, provided ext4 will have the same change, I'm fine with the patch.
So how is it with ext4?

									Honza
> ---
> 
> diff --git a/Documentation/filesystems/ext3.txt b/Documentation/filesystems/ext3.txt
> index 05d5cf1..8b8d973 100644
> --- a/Documentation/filesystems/ext3.txt
> +++ b/Documentation/filesystems/ext3.txt
> @@ -33,7 +33,7 @@ journal_dev=devnum	When the external journal device's major/minor numbers
> 			in devnum.
> 
> noload			Don't load the journal on mounting. Note that this forces
> -			mount of inconsistent filesystem, which can lead to
> +norecovery		mount of inconsistent filesystem, which can lead to
> 			various problems.
> 
> data=journal		All data are committed into the journal prior to being
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 427496c..c14fb95 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -636,6 +636,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs)
> 	if (test_opt(sb, DATA_ERR_ABORT))
> 		seq_puts(seq, ",data_err=abort");
> 
> +	if (test_opt(sb, NOLOAD))
> +		seq_puts(seq, ",norecovery");
> +
> 	ext3_show_quota_options(seq, sb);
> 
> 	return 0;
> @@ -818,6 +821,7 @@ static const match_table_t tokens = {
> 	{Opt_reservation, "reservation"},
> 	{Opt_noreservation, "noreservation"},
> 	{Opt_noload, "noload"},
> +	{Opt_noload, "norecovery"},
> 	{Opt_nobh, "nobh"},
> 	{Opt_bh, "bh"},
> 	{Opt_commit, "commit=%u"},
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html