linux-ext4 - Re: [PATCH 2/5] quota: Implement project id support for generic quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Mar 2010 16:17:53 +0300
From:	Dmitry Monakhov <dmonakhov@...nvz.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 2/5] quota: Implement project id support for generic quota

Christoph Hellwig <hch@...radead.org> writes:

> On Thu, Mar 04, 2010 at 09:34:34PM +0300, Dmitry Monakhov wrote:
>>  		case GRPQUOTA:
>>  			return in_group_p(dquot->dq_id);
>> +		case PRJQUOTA:
>> +			/* XXX: Currently there is no way to understand
>> +			   which project_id this task belonges to, So print
>> +			   a warn message unconditionally. -dmon */
>> +			return 1;
>
> Note that this is different from the XFS behaviour, which neve warns
> for project quota.  In fact project quota in XFS traditionally doesn't
> even return EDQUOT but ENOSPC instead, as it's not a traditional quota
> mechanism but filesystem containerization.
Yes, i know, but imho it is better to return true EDQUOT to understand
what is really happen.
>
> Otherwise the patch looks good except for the ifdef mess already comment
> on in the previous patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html