[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <877hpjj88k.fsf@openvz.org>
Date: Thu, 11 Mar 2010 16:30:51 +0300
From: Dmitry Monakhov <dmonakhov@...nvz.org>
To: Christoph Hellwig <hch@...radead.org>
Cc: linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 3/5] ext4: Implement project ID support for ext4 filesystem
Christoph Hellwig <hch@...radead.org> writes:
> On Thu, Mar 04, 2010 at 09:34:35PM +0300, Dmitry Monakhov wrote:
>> Project id is stored on disk inside xattr usually inside ibody.
>> Xattr is used only as a data storage, It has not user visible xattr
>> interface.
>>
>> * User interface
>> Project id is accessible via generic xattr interface "system.project_id"
>>
>> TODO: implement e2libfs support for project_id.
>
> I think you'd be much better off storing it inide the inode core itself.
> E.g. you could ue the never used fragment address in the ext2/3/4 disk
> inode.http://patchwork.ozlabs.org/patch/38766
This was already discussed at the first RFC
http://patchwork.ozlabs.org/patch/38766
and Andreas was strongly against this idea.
>
>> +#ifdef CONFIG_QUOTA
>> + qid[PRJQUOTA] = new_prjid;
>> + ret = inode->i_sb->dq_op->transfer(inode, qid, 1 << PRJQUOTA);
>> + if (ret)
>> + return ret;
>> +#endif
>
> This needs to be updated to use dquot_transfer directly.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists