linux-ext4 - Re: [PATCH 3/5] ext4: Implement project ID support for ext4 filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Mar 2010 15:25:00 -0600
From:	Andreas Dilger <adilger@....com>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	tytso@....edu, hch@...radead.org, jack@...e.cz,
	david@...morbit.com, viro@...IV.linux.org.uk, xemul@...nvz.org
Subject: Re: [PATCH 3/5] ext4: Implement project ID support for ext4 filesystem

On 2010-03-18, at 08:02, Dmitry Monakhov wrote:
> * Disk layout
>  Project id is stored on disk inside xattr usually inside ibody.
>  Xattr is used only as a data storage, It has not user visible xattr
>  interface.
>
> * User interface
>  Project id is accessible via generic xattr interface  
> "system.project_id"
>
> +#define EXT4_XATTR_INDEX_PROJECT_ID	        7

If you are making this attribute available to userspace via  
system.project_id, doesn't it make sense to store it on disk as  
system.project_id also (i.e. in the "system" namespace)?

Alternately, the "trusted" namespace is already intended for use as  
"accessible only by root/kernel" semantics if this is what you are  
trying to achieve.

I'm also with the statement "It has not user visible xattr interface"  
yet you also write "Project id is accessible via generic xattr  
interface".  Why bother having this complexity when you are free to  
make the two identical?

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html