linux-ext4 - Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_regular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100322182645.GI11560@thunk.org>
Date:	Mon, 22 Mar 2010 14:26:45 -0400
From:	tytso@....edu
To:	jing zhang <zj.barak@...il.com>
Cc:	linux-ext4 <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@....com>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove unnecessary operation in
 ext4_mb_regular_allocator()

On Mon, Mar 22, 2010 at 10:35:54PM +0800, jing zhang wrote:
> From: Jing Zhang <zj.barak@...il.com>
> 
> Date: Mon Mar 22 22:20:38     2010
> 
> 1, In one of the hot functions in mballoc.c, unnecessary operation on
>        struct ext4_group_desc *desc;
>     is removed.
> 
> 2, Unlike spin_lock() and spin_unlock(), ext4_mb_load_buddy() is
> companied by ext4_mb_release_desc. And it is hard, at least for me, to
> get sure that ext4_mb_release_desc has little to do with struct
> ext4_group_desc, and for those readers as well, whose native language
> is not English. It seems the choice includes
>      ext4_mb_release_buddy
>      ext4_mb_put_buddy
>      ext4_mb_unload_buddy
> and I like the last one.

Please separate things like this into two separate patches; it makes
them much easier to review.

Thanks,

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html