linux-ext4 - Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_regular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <06B9B10D-6B78-4A44-9DFC-85FD66E8D57B@sun.com>
Date:	Mon, 22 Mar 2010 21:42:01 -0600
From:	Andreas Dilger <adilger@....com>
To:	jing zhang <zj.barak@...il.com>
Cc:	linux-ext4 <linux-ext4@...r.kernel.org>,
	"Theodore Ts'o" <tytso@....edu>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove unnecessary operation in
 ext4_mb_regular_allocator()

On 2010-03-22, at 08:35, jing zhang wrote:
> @@ -2027,7 +2027,7 @@ repeat:
>
> 		for (i = 0; i < ngroups; group++, i++) {
> 			struct ext4_group_info *grp;
> -			struct ext4_group_desc *desc;
> +			/* struct ext4_group_desc *desc; */
>
> 			if (group == ngroups)
> 				group = 0;
> @@ -2045,12 +2045,12 @@ repeat:
>
> 			ac->ac_groups_scanned++;
> -			desc = ext4_get_group_desc(sb, group, NULL);
> +			/* desc = ext4_get_group_desc(sb, group, NULL); */
> 			if (cr == 0)
> 				ext4_mb_simple_scan_group(ac, &e4b);
> 			else if (cr == 1 &&


Rather than commenting these lines out, please just delete them.  They  
serve no purpose, and leaving them in the code will just add confusion  
in the future.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html