linux-ext4 - Re: [PATCH] ext4/super.c: Replace CONTIG_EXT{2,3}_FS by CONFIG_EXT{2,3}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100324162747.GI2159@thunk.org>
Date:	Wed, 24 Mar 2010 12:27:47 -0400
From:	tytso@....edu
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCH] ext4/super.c: Replace CONTIG_EXT{2,3}_FS by
 CONFIG_EXT{2,3}_FS

On Wed, Mar 24, 2010 at 11:21:59AM -0500, Eric Sandeen wrote:
> On 03/24/2010 11:12 AM, tytso@....edu wrote:
> > Thanks for catching this!  This should fix it up...
> > 
> >        	   	    	   	       	   - Ted
> > 
> > ext4: Fix build error when EXT4_USE_FOR_EXT23 disabled
> > 
> > Fix a stupid type (CONTIG != CONFIG) and a stupid assumption that
> > ext3_fs_type would always be defined.
> > 
> > (The build failure could also happen when EXT4_USE_FOR_EXT23 is
> > enabled and ext3 is built as a module.)
> 
> A little late, but right now we have this in Kconfig:
> 
> config EXT4_USE_FOR_EXT23
>         bool "Use ext4 for ext2/ext3 file systems"
>         depends on EXT4_FS
>         depends on EXT3_FS=n || EXT2_FS=n
> 
> do we really want "||" ?
> 
> so, if you turn off ext2, but leave ext3 on, it will ask you if you want
> to use ext4 for ext3?  That doesn't make sense to me.

Well, the idea is you can use ext4 instead of ext2 or ext3.  So if
ext3 is turned on, but ext2 is off, then the option will use ext4 for
ext2, but ext3 will stay ext3.

This is explained in more detail in the help message.  I guess we
could make "ext2/ext3 filesystems" be "ext2 or ext3 filesystems" and
then add a slightly more explicit explanation in the help text....

     	   	    	 	  	      	 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html