linux-ext4 - Re: [PATCH] ext4: remove unnecessary operation in ext4_mb_regular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878w9hd46s.fsf@linux.vnet.ibm.com>
Date:	Wed, 24 Mar 2010 22:53:23 +0530
From:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	jing zhang <zj.barak@...il.com>, tytso@....edu
Cc:	linux-ext4 <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@....com>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove unnecessary operation in
 ext4_mb_regular_allocator()

On Tue, 23 Mar 2010 20:40:29 +0800, jing zhang <zj.barak@...il.com> wrote:
> 2010/3/23, tytso@....edu <tytso@....edu>:
> > On Mon, Mar 22, 2010 at 10:35:54PM +0800, jing zhang wrote:
> >> From: Jing Zhang <zj.barak@...il.com>
> >>
> >> Date: Mon Mar 22 22:20:38     2010
> >>
> >> 1, In one of the hot functions in mballoc.c, unnecessary operation on
> >>        struct ext4_group_desc *desc;
> >>     is removed.
> 
> ---
> 
> diff --git a/linux-2.6.32/fs/ext4/mballoc.c b/ext4_mm_leak/mballoc5.c
> index bba1282..fb18199 100644
> --- a/linux-2.6.32/fs/ext4/mballoc.c
> +++ b/ext4_mm_leak/mballoc5.c
> @@ -2027,7 +2027,6 @@ repeat:
> 
>  		for (i = 0; i < ngroups; group++, i++) {
>  			struct ext4_group_info *grp;
> -			struct ext4_group_desc *desc;
> 
>  			if (group == ngroups)
>  				group = 0;
> @@ -2050,7 +2049,6 @@ repeat:
>  			}
> 
>  			ac->ac_groups_scanned++;
> -			desc = ext4_get_group_desc(sb, group, NULL);
>  			if (cr == 0)
>  				ext4_mb_simple_scan_group(ac, &e4b);
>  			else if (cr == 1 &&
> 


We missed that in commit 75507efb1372b6acf1aa6bf00ebd49ce196fd994
ealier we had an uninit check around that. 


-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html