[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ac8f92701003240514l77f5b597h605b06b5f6140674@mail.gmail.com>
Date: Wed, 24 Mar 2010 20:14:46 +0800
From: jing zhang <zj.barak@...il.com>
To: tytso@....edu
Cc: linux-ext4 <linux-ext4@...r.kernel.org>,
Andreas Dilger <adilger@....com>,
Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove unnecessary operation in
ext4_mb_regular_allocator()
2010/3/24, tytso@....edu <tytso@....edu>:
> Thanks for separating the patches!
>
> Since you included a Signed-off-by in the earlier version of the
> patches, I'll assume it applies two these two patches. For future
> reference, though, it saves me time and effort if you follow the
> guidelines specified in Documentation/SubmittingPatches, especially
> the section 15, ("The canonical patch format") which talks about using
> a separate e-mail for each patch (chained together using the
> In-reply-to: mail header fields).
>
> Among other reasons, it allows me to keep track of patches using the
> patchwork tool (see: http://patchwork.ozlabs.org/project/linux-ext4)
> so I don't forget about patches which are sent to me. It also allows
> me to use tools such as "git am" to automatically apply patches.
>
> Note that there are tools like "git format-patches" and "git
> send-email" which make it very easy to send out patches which are
> compliant to the these recomendations. They are not required, but
> they do make your job easier.
>
> I'll fix up these patches by hand, so it's no big deal, but in the
> future, it streamlines things if you follow the SubmittingPatches
> guidelines. (See also the SubmitChecklist in the Documentation
> directory of the Linux sources).
>
> Many thanks,
>
> - Ted
>
Evening,
Sorry for my last reply that causes you have to deal the patches by
hand, and thank you, Ted, for your patience.
I will try hard to follow the guidelines specified in
Documentation/SubmittingPatches, and to learn how to git
format-patches.
Best
- zj
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists