linux-ext4 - [PATCH] ext4: page_cache pages over pinned in ext4_mb_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac8f92701003240600o5ce6a682i431de77bef66b736@mail.gmail.com>
Date:	Wed, 24 Mar 2010 21:00:34 +0800
From:	jing zhang <zj.barak@...il.com>
To:	linux-ext4 <linux-ext4@...r.kernel.org>
Cc:	"Theodore Ts'o" <tytso@....edu>, Andreas Dilger <adilger@....com>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Subject: [PATCH] ext4: page_cache pages over pinned in ext4_mb_free_metadata()

From: Jing Zhang <zj.barak@...il.com>

Date: Wed Mar 24 20:38:48     2010

The function, ext4_mb_free_metadata(), is called after
     ext4_mb_load_buddy(sb, block_group, &e4b);
and before
     ext4_mb_release_desc(&e4b);
in the function, ext4_mb_free_blocks(), so the bd_bitmap_page and
bd_buddy_page of e4b are well managed.

If for special purpose, page_cache_get() is issued on these two pages,
there should also be page_cache_release() issued correspondingly, or
the two pages are over pinned.

Cc: Theodore Ts'o <tytso@....edu>
Cc: Andreas Dilger <adilger@....com>
Cc: Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Signed-off-by: Jing Zhang <zj.barak@...il.com>

---

--- linux-2.6.32/fs/ext4/mballoc.c	2009-12-03 11:51:22.000000000 +0800
+++ ext4_mm_leak/mballoc6.c	2010-03-24 20:31:52.000000000 +0800
@@ -4361,15 +4361,6 @@ ext4_mb_free_metadata(handle_t *handle,
 	new_node = &new_entry->node;
 	block = new_entry->start_blk;

-	if (!*n) {
-		/* first free block exent. We need to
-		   protect buddy cache from being freed,
-		 * otherwise we'll refresh it from
-		 * on-disk bitmap and lose not-yet-available
-		 * blocks */
-		page_cache_get(e4b->bd_buddy_page);
-		page_cache_get(e4b->bd_bitmap_page);
-	}
 	while (*n) {
 		parent = *n;
 		entry = rb_entry(parent, struct ext4_free_data, node);
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html