linux-ext4 - Re: nobh mount option in ext3/4?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100531175557.GC5334@quack.suse.cz>
Date:	Mon, 31 May 2010 19:55:58 +0200
From:	Jan Kara <jack@...e.cz>
To:	Christoph Hellwig <hch@....de>
Cc:	jack@...e.cz, tytso@....edu, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: nobh mount option in ext3/4?

On Mon 31-05-10 14:40:51, Christoph Hellwig wrote:
> ext3 and ext4 heave inherited the nobh option from ext2, but the
> implementation is rather interesting.  Except for the usual
> option parsing / display it's only respected in
> ext3_writeback_writepage/ext4_writepage and the truncate_page
> implementation.  Given that we don't take any more than usual
> care to not create buffers heads during read this is not going
> to effect a whole lot.
> 
> Is there a good reason to keep these options and the associated
> code complexity?  I'd be rather surprised if it gets any sufficient
> testing..
  IMHO nobh can go away from ext3/ext4. I would be also in favor of
removing all the nobh logic from VFS and ext2 but for ext2 it saves some
low memory so some people might actually use it.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html