linux-ext4 - Re: [PATCH] EXT4: move aio completion after unwritten extent conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Jun 2010 11:41:13 -0700
From:	Jiaying Zhang <jiayingz@...gle.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	tytso@....edu, c@...gle.com
Subject: Re: [PATCH] EXT4: move aio completion after unwritten extent 
	conversion

On Mon, Jun 28, 2010 at 7:49 AM, Christoph Hellwig <hch@...radead.org> wrote:
>
> >       if (io_end->flag != EXT4_IO_UNWRITTEN){
> >               ext4_free_io_end(io_end);
> >               iocb->private = NULL;
> > -             goto out;
> > +out:
> > +             if (is_async)
> > +                     aio_complete(iocb, ret, 0);
> > +             return;
>
> I'd suggest keeping the out label at the end of the function.  Without
> that the code gets unreadable very quickly.
>
I am fine with either. Having the 'out' exit label here saves us a jump in the
common code path while keeping it at the end of the function comply better
with the kernel code style. I will let Ted decide which one to take.

> >       io_end->size = size;
> > -     io_end->flag = EXT4_IO_UNWRITTEN;
>
> Why is this initialization removed?
>
This change is not related to the bug fix. I just realized that this
initialization seems to be unnecessary because we should already
return in the case that (io_end->flag != EXT4_IO_UNWRITTEN)
at the beginning of the function.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html