linux-ext4 - Re: [PATCH] EXT4: move aio completion after unwritten extent conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100628144956.GA21331@infradead.org>
Date:	Mon, 28 Jun 2010 10:49:56 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Jiaying Zhang <jiayingz@...gle.com>
Cc:	hch@...radead.org, linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, tytso@....edu, c@...gle.com
Subject: Re: [PATCH] EXT4: move aio completion after unwritten extent
 conversion

>  	if (io_end->flag != EXT4_IO_UNWRITTEN){
>  		ext4_free_io_end(io_end);
>  		iocb->private = NULL;
> -		goto out;
> +out:
> +		if (is_async)
> +			aio_complete(iocb, ret, 0);
> +		return;

I'd suggest keeping the out label at the end of the function.  Without
that the code gets unreadable very quickly.

>  	io_end->size = size;
> -	io_end->flag = EXT4_IO_UNWRITTEN;

Why is this initialization removed?

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html