linux-ext4 - Re: [PATCH V4 5/8] Cleancache: ext3 hook for cleancache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C7C3666.2080601@goop.org>
Date:	Mon, 30 Aug 2010 15:53:26 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Dan Magenheimer <dan.magenheimer@...cle.com>
CC:	chris.mason@...cle.com, viro@...iv.linux.org.uk,
	akpm@...ux-foundation.org, adilger@....com, tytso@....edu,
	mfasheh@...e.com, joel.becker@...cle.com, matthew@....cx,
	linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
	ocfs2-devel@....oracle.com, linux-mm@...ck.org, ngupta@...are.org,
	JBeulich@...ell.com, kurt.hackel@...cle.com, npiggin@...nel.dk,
	dave.mccracken@...cle.com, riel@...hat.com, avi@...hat.com,
	konrad.wilk@...cle.com, mel@....ul.ie, yinghan@...gle.com,
	gthelen@...gle.com
Subject: Re: [PATCH V4 5/8] Cleancache: ext3 hook for cleancache

 On 08/30/2010 03:32 PM, Dan Magenheimer wrote:
> [PATCH V4 5/8] Cleancache: ext3 hook for cleancache
>
> Filesystems must explicitly enable cleancache by calling
> cleancache_init_fs anytime a instance of the filesystem
> is mounted and must save the returned poolid.  For ext3,
> all other cleancache hooks are in the VFS layer including
> the matching cleancache_flush_fs hook which must be
> called on unmount.
>
> Signed-off-by: Dan Magenheimer <dan.magenheimer@...cle.com>
> Acked-by: Andreas Dilger <adilger@....com>
>
> Diffstat:
>  super.c                                  |    2 ++
>  1 file changed, 2 insertions(+)
>
> --- linux-2.6.36-rc3/fs/ext3/super.c	2010-08-29 09:36:04.000000000 -0600
> +++ linux-2.6.36-rc3-cleancache/fs/ext3/super.c	2010-08-30 09:20:42.000000000 -0600
> @@ -37,6 +37,7 @@
>  #include <linux/quotaops.h>
>  #include <linux/seq_file.h>
>  #include <linux/log2.h>
> +#include <linux/cleancache.h>
>  
>  #include <asm/uaccess.h>
>  
> @@ -1349,6 +1350,7 @@ static int ext3_setup_super(struct super
>  	} else {
>  		ext3_msg(sb, KERN_INFO, "using internal journal");
>  	}
> +	sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE);

Do you really need to pass in the page size?  What about just
"cleancache_init_fs(sb)" rather than exposing the
"sb->cleancache_poolid"?  In other words, what if you want to do
more/other per-filesystem init at some point?

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html