linux-ext4 - RE: [PATCH V4 5/8] Cleancache: ext3 hook for cleancache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91408f0c-0135-427f-b148-446f54b232eb@default>
Date:	Mon, 30 Aug 2010 17:57:04 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Chris Mason <chris.mason@...cle.com>, viro@...iv.linux.org.uk,
	akpm@...ux-foundation.org, adilger@....com, tytso@....edu,
	mfasheh@...e.com, Joel Becker <joel.becker@...cle.com>,
	matthew@....cx, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-ext4@...r.kernel.org, ocfs2-devel@....oracle.com,
	linux-mm@...ck.org, ngupta@...are.org, JBeulich@...ell.com,
	Kurt Hackel <kurt.hackel@...cle.com>, npiggin@...nel.dk,
	Dave Mccracken <dave.mccracken@...cle.com>, riel@...hat.com,
	avi@...hat.com, Konrad Wilk <konrad.wilk@...cle.com>,
	mel@....ul.ie, yinghan@...gle.com, gthelen@...gle.com
Subject: RE: [PATCH V4 5/8] Cleancache: ext3 hook for cleancache

> > @@ -1349,6 +1350,7 @@ static int ext3_setup_super(struct super
> >  	} else {
> >  		ext3_msg(sb, KERN_INFO, "using internal journal");
> >  	}
> > +	sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE);
> 
> Do you really need to pass in the page size?  What about just
> "cleancache_init_fs(sb)" rather than exposing the
> "sb->cleancache_poolid"?  In other words, what if you want to do
> more/other per-filesystem init at some point?

IIRC, I think I was trying to stay away from including
fs.h in cleancache.h (or one of its predecessors).  I
agree that that no longer makes sense and it is cleaner
as you suggest.  Will change.

Thanks,
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html