linux-ext4 - Re: Broken e2fsck i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100925122403.GE9597@thunk.org>
Date:	Sat, 25 Sep 2010 08:24:03 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Justin Maggard <jmaggard10@...il.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: Broken e2fsck i_blocks repair

On Wed, Sep 01, 2010 at 04:01:22PM -0700, Justin Maggard wrote:
> I've mentioned this before on here, but I never verified whether or
> not it was actually broken.  I have done so today.  I manually
> modified the block count of a 3TB file using debugfs, then ran e2fsck
> on it.  e2fsck claimed to repair it, but would throw an error on every
> subsequent e2fsck run for the same issue.  The reason is
> inode->osd2.linux2.l_i_blocks_hi is always set to 0 if e2fsck is told
> to fix it.  This is an issue in both stable 1.41.12, and in master.
> This patch fixes it for me, but is there anything else that needs to
> get checked here?

Sorry for the delay; September has been rather busy for me.  This fix
has been checked in and pushed out to the e2fsprogs git repository.
I've taken a look and there doesn't seem to be any other places where
this mistake could have happened.

Thanks for pointing it out!

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html