linux-ext4 - Re: [PATCH] don't use ext4_allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101009230457.GD11237@thunk.org>
Date:	Sat, 9 Oct 2010 19:04:58 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] don't use ext4_allocation_contexts for tracing

On Fri, Aug 20, 2010 at 02:51:43PM -0500, Eric Sandeen wrote:
> Many tracepoints were populating an ext4_allocation_context
> to pass in, but this requires a slab allocation even when
> tracepoints are off.  In fact, 4 of 5 of these allocations
> were only for tracing.  In addition, we were only using a
> small fraction of the 144 bytes of this structure for this
> purpose.
> 
> We can do away with all these alloc/frees of the ac and
> simply pass in the bits we care about, instead.
> 
> I tested this by turning on tracing and running through
> xfstests on x86_64.  I did not actually do anything with
> the trace output, however.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Added to the patch tree, thanks!

I made a slight change to drop passing in the logical parameter to
trace_ext4_mballoc_discard() and trace_ext4_mballoc_free(), since
passing in 0 all the time doesn't really buy us much.  :-)

	     	     	  	  	 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html