linux-ext4 - Re: [PATCH] ext4: queue conversion after adding to inode's completed IO list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101009231451.GE11237@thunk.org>
Date:	Sat, 9 Oct 2010 19:14:51 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Jiaying Zhang <jiayingz@...gle.com>
Subject: Re: [PATCH] ext4: queue conversion after adding to inode's
 completed IO list

On Thu, Oct 07, 2010 at 12:23:56PM -0500, Eric Sandeen wrote:
> On 08/06/2010 02:52 PM, Eric Sandeen wrote:
> > By queuing the io end on the unwritten workqueue before adding it
> > to our inode's list of completed IOs, I think we run the risk
> > of the work getting completed, and the IO freed, before we try
> > to add it to the inode's i_completed_io_list.
> > 
> > It should be safe to add it to the inode's list of completed
> > IOs, and -then- queue it for completion, I think.
> 
> Ping? would be good to fix this race, this has jiaying's ack too.

Added to the ext4 patch queue, thanks for the ping.

      	     	  	       	      	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html