linux-ext4 - Re: [PATCH] e2fsprogs: create com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4DFB643B.3020600@redhat.com>
Date:	Fri, 17 Jun 2011 09:27:07 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	"Ted Ts'o" <tytso@....edu>
CC:	ext4 development <linux-ext4@...r.kernel.org>, mitchb@....edu,
	Bruce Cassidy <bruce@...mcloud.com>
Subject: Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir

On 6/16/11 9:31 PM, Ted Ts'o wrote:
> On Thu, Jun 16, 2011 at 03:39:07PM -0500, Eric Sandeen wrote:
>>> Hm, now in a "make rpm" build which has source in one place and rpm build
>>> area in another:
>>>
>>> /bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
>>>
>>> so I'm not quite sure how to work around this.
>>>
>>> Maybe in the end it does have to be packaging-specific, with the
>>> link created by the distro pkg scripts...?
>>
>> Ted, your change broke any builds span 2 different filesystems.
> 
> I thought I fixed this with commit 1e082c62?

Oh, maybe you did; I didn't see any reply to my original problem report,
and I didn't see the patch sent to the list (maybe I missed it?)

So I assumed it wasn't yet fixed, TBH I don't usually build cross-fs
that way so hadn't actually retested, sorry.  Seems like it should
be fine now, thanks.

As for Andreas' comment:

> I had to return the "-s" back as well, but the current code looks OK.
> The chance of separate filesystems for /usr/include and /usr/include/et
> being used seems vanishingly small.

my problem was actually during the RPM packaging, so a slightly different
situation.

-Eric

> Which Makefile is breaking?  Is this the one in lib/et/Makefile.in?
> It currently reads:
> 
>    $(Q) (cd $(DESTDIR)$(includedir) ;\
>    	$(LN) $(LINK_INSTALL_FLAGS) et/com_err.h . )
> 
> and I don't see how that could have generated the error you've cited
> above...
> 
> 						- Ted
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html