linux-ext4 - Re: [PATCH] e2fsprogs: create com

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1A2DB8F9-BD3B-436E-886D-431A15796AC3@dilger.ca>
Date:	Thu, 16 Jun 2011 21:54:20 -0600
From:	Andreas Dilger <adilger@...ger.ca>
To:	Ted Ts'o <tytso@....edu>
Cc:	Eric Sandeen <sandeen@...hat.com>,
	ext4 development <linux-ext4@...r.kernel.org>, mitchb@....edu,
	Bruce Cassidy <bruce@...mcloud.com>
Subject: Re: [PATCH] e2fsprogs: create com_err.h symlink in includedir

On 2011-06-16, at 8:31 PM, Ted Ts'o wrote:
> On Thu, Jun 16, 2011 at 03:39:07PM -0500, Eric Sandeen wrote:
>>> Hm, now in a "make rpm" build which has source in one place and rpm build
>>> area in another:
>>> 
>>> /bin/ln: creating hard link `/home/sandeen/rpmbuild/BUILDROOT/e2fsprogs-1.41.14-0.x86_64/usr/include/com_err.h' => `/usr/include/et/com_err.h': Invalid cross-device link
>>> 
>>> so I'm not quite sure how to work around this.
>>> 
>>> Maybe in the end it does have to be packaging-specific, with the
>>> link created by the distro pkg scripts...?
>> 
>> Ted, your change broke any builds span 2 different filesystems.
> 
> I thought I fixed this with commit 1e082c62?
> 
> Which Makefile is breaking?  Is this the one in lib/et/Makefile.in?
> It currently reads:
> 
>  $(Q) (cd $(DESTDIR)$(includedir) ;\
>  	$(LN) $(LINK_INSTALL_FLAGS) et/com_err.h . )
> 
> and I don't see how that could have generated the error you've cited
> above...

I had to return the "-s" back as well, but the current code looks OK.
The chance of separate filesystems for /usr/include and /usr/include/et
being used seems vanishingly small.

Cheers, Andreas





--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html