linux-ext4 - Re: [PATCH v2] ext4: avoid redundant cache finding if flags not cantian PUNCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110627195911.GD20655@tux1.beaverton.ibm.com>
Date:	Mon, 27 Jun 2011 12:59:11 -0700
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	Robin Dong <hao.bigrat@...il.com>
Cc:	linux-ext4@...r.kernel.org, Robin Dong <sanbai@...bao.com>
Subject: Re: [PATCH v2] ext4: avoid redundant cache finding if flags not
	cantian PUNCH_OUT

On Mon, Jun 27, 2011 at 06:45:13PM +0800, Robin Dong wrote:
> Subject: [PATCH v2] ext4: avoid redundant cache finding if flags not cantian

I suspect you mean "contain" as opposed to "cantian".

> In old code, ext4 will find extent in cache first even flags does
> not contian PUNCH_OUT, that may waste some time.

Same here ("contian").

--D
> 
> Signed-off-by: Robin Dong <sanbai@...bao.com>
> Reviewed-by: Lukas Czerner <lczerner@...hat.com>
> ---
>  fs/ext4/extents.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index eb63c7b..fed2633 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3358,8 +3358,8 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
>  	trace_ext4_ext_map_blocks_enter(inode, map->m_lblk, map->m_len, flags);
> 
>  	/* check in cache */
> -	if (ext4_ext_in_cache(inode, map->m_lblk, &newex) &&
> -		((flags & EXT4_GET_BLOCKS_PUNCH_OUT_EXT) == 0)) {
> +	if (!(flags & EXT4_GET_BLOCKS_PUNCH_OUT_EXT) &&
> +		ext4_ext_in_cache(inode, map->m_lblk, &newex)) {
>  		if (!newex.ee_start_lo && !newex.ee_start_hi) {
>  			if ((flags & EXT4_GET_BLOCKS_CREATE) == 0) {
>  				/*
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html