linux-ext4 - Re: [PATCH 3/4] Ext4: handle SEEK_HOLE/SEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E0A10AD.3040905@redhat.com>
Date:	Tue, 28 Jun 2011 13:34:37 -0400
From:	Josef Bacik <josef@...hat.com>
To:	Andreas Dilger <adilger@...ger.ca>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 3/4] Ext4: handle SEEK_HOLE/SEEK_DATA generically

On 06/28/2011 12:29 PM, Andreas Dilger wrote:
> On 2011-06-28, at 9:33 AM, Josef Bacik wrote:
>> Since Ext4 has its own lseek we need to make sure it handles
>> SEEK_HOLE/SEEK_DATA.  For now just do the same thing that is done in the generic
>> case, somebody else can come along and make it do fancy things later.  Thanks,
> 
> Josef,
> are you planning to add an ext4-based version of this in the future?
> Another possibility is to have a generic SEEK_{DATA,HOLE} -> FIEMAP
> converter, since there are several filesystems that already support
> FIEMAP (ext3, ext4, etc).

Probably not, I'm pretty tied up in Btrfs work.  I had thought about
doing a generic one that used fiemap but that's a lot of work and I'm
lazy :).  Plus everybody who does fiemap all have different answers on
what is a hole.  For example btrfs can safely say prealloc'ed space is a
hole, but xfs can't (and I *think* ext4 can't either but I'm not sure).
 So I figured just leaving it up to each individual fs'es instead of
hobbling together a generic fiemap->seek_hole/data translator was more
prudent, especially since everybody will eventually want to do their own
thing.  Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html