linux-ext4 - [PATCH] e2fsprogs: use ALL_CFLAGS to build gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Oct 2011 11:14:15 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
Subject: [PATCH] e2fsprogs: use ALL_CFLAGS to build gen_crc32ctable

With just BUILD_CFLAGS this we don't get the right include
paths (i.e. within the tree) to build the gen_crc32ctable binary.

Signed-off-by: Eric Sandeen <sandeen@...hat.com>
---

I think that the rule could probably be removed altogether, and
gen_crc32ctable.o would be built from gen_crc32ctable.c, and
the normal dependencies & rules would build gen_crc32ctable.
But this seems like the most obvious change.

diff --git a/lib/ext2fs/Makefile.in b/lib/ext2fs/Makefile.in
index 3de9f87..07a0db18 100644
--- a/lib/ext2fs/Makefile.in
+++ b/lib/ext2fs/Makefile.in
@@ -413,7 +413,7 @@ $(OBJS): subdirs
 
 gen_crc32ctable: $(srcdir)/gen_crc32ctable.c
 	$(E) "	CC $@"
-	$(Q) $(BUILD_CC) $(BUILD_CFLAGS) -o gen_crc32ctable \
+	$(Q) $(BUILD_CC) $(ALL_CFLAGS) -o gen_crc32ctable \
 		$(srcdir)/gen_crc32ctable.c
 
 crc32c_table.h: gen_crc32ctable

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html