linux-ext4 - Re: e2fsprogs: use ALL_CFLAGS to build gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111004030232.GA28372@thunk.org>
Date:	Mon, 3 Oct 2011 23:02:32 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: e2fsprogs: use ALL_CFLAGS to build gen_crc32ctable

On Mon, Oct 03, 2011 at 06:14:15AM -0000, Eric Sandeen wrote:
> With just BUILD_CFLAGS this we don't get the right include
> paths (i.e. within the tree) to build the gen_crc32ctable binary.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

We can't use ALL_CFLAGS because in the cross compilation case, it
might contain some compiler directives that make sense for the target
platform, but not for the host platform.  BUILD_CFLAGS is specifically
designed for this case.  For programs like gen_crc32ctable that need
to compiled and run on the host OS, you have to do the following so
the right thing happens when you are cross-compiling e2fsprogs (yes,
there are people who do this!):

gen_crc32ctable: $(srcdir)/gen_crc32ctable.c
	$(E) "	CC $@"
	$(Q) $(BUILD_CC) $(BUILD_CFLAGS) -o gen_crc32ctable \
		$(srcdir)/gen_crc32ctable.c

Note the use of $(BUILD_CC) instead of $(CC).

The better fix is to note that gen_crc32ctable doesn't actually need
anything from ext2fs.h, and move that #include to crc32c.c.

	      		    	      - Ted

commit 8232f2ddaece256afd323eb5a289a5ec1b7fbd1a
Author: Theodore Ts'o <tytso@....edu>
Date:   Mon Oct 3 22:49:45 2011 -0400

    libext2fs: move #include "ext2fs.h" from crc32c_defs.h to crc32c.c
    
    The byte swap functions which are defined in ext2fs.h are only needed
    by crc32.c, and not by gen_crc32ctable.c.  The gen_crc32ctable program
    needs to be compiled on the host OS, where ext2fs.h may not be
    present.  So move the use of the header function to crc32c.c, to avoid
    compilation problems.
    
    Signed-off-by: "Theodore Ts'o" <tytso@....edu>

diff --git a/lib/ext2fs/crc32c.c b/lib/ext2fs/crc32c.c
index 65bca5c..6be4336 100644
--- a/lib/ext2fs/crc32c.c
+++ b/lib/ext2fs/crc32c.c
@@ -40,6 +40,23 @@
 #define PTR_ALIGN(p, a)		((typeof(p))ALIGN((unsigned long)(p), (a)))
 #include "crc32c_defs.h"
 
+#include "ext2fs.h"
+#ifdef WORDS_BIGENDIAN
+#define __constant_cpu_to_le32(x) ___constant_swab32((x))
+#define __constant_cpu_to_be32(x) (x)
+#define __be32_to_cpu(x) (x)
+#define __cpu_to_be32(x) (x)
+#define __cpu_to_le32(x) (ext2fs_cpu_to_le32((x)))
+#define __le32_to_cpu(x) (ext2fs_le32_to_cpu((x)))
+#else
+#define __constant_cpu_to_le32(x) (x)
+#define __constant_cpu_to_be32(x) ___constant_swab32((x))
+#define __be32_to_cpu(x) (ext2fs_be32_to_cpu((x)))
+#define __cpu_to_be32(x) (ext2fs_cpu_to_be32((x)))
+#define __cpu_to_le32(x) (x)
+#define __le32_to_cpu(x) (x)
+#endif
+
 #if CRC_LE_BITS > 8
 # define tole(x) (__force uint32_t) __constant_cpu_to_le32(x)
 #else
diff --git a/lib/ext2fs/crc32c_defs.h b/lib/ext2fs/crc32c_defs.h
index ced4f67..023f2c0 100644
--- a/lib/ext2fs/crc32c_defs.h
+++ b/lib/ext2fs/crc32c_defs.h
@@ -42,23 +42,6 @@
 		(((uint32_t)(x) & (uint32_t)0xff000000UL) >> 24)))
 
 
-#include "ext2fs.h"
-#ifdef WORDS_BIGENDIAN
-#define __constant_cpu_to_le32(x) ___constant_swab32((x))
-#define __constant_cpu_to_be32(x) (x)
-#define __be32_to_cpu(x) (x)
-#define __cpu_to_be32(x) (x)
-#define __cpu_to_le32(x) (ext2fs_cpu_to_le32((x)))
-#define __le32_to_cpu(x) (ext2fs_le32_to_cpu((x)))
-#else
-#define __constant_cpu_to_le32(x) (x)
-#define __constant_cpu_to_be32(x) ___constant_swab32((x))
-#define __be32_to_cpu(x) (ext2fs_be32_to_cpu((x)))
-#define __cpu_to_be32(x) (ext2fs_cpu_to_be32((x)))
-#define __cpu_to_le32(x) (x)
-#define __le32_to_cpu(x) (x)
-#endif
-
 #if (__GNUC__ >= 3)
 #define likely(x)	__builtin_expect(!!(x), 1)
 #define unlikely(x)	__builtin_expect(!!(x), 0)
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html