linux-ext4 - Re: [PATCH] ext3/balloc.c: local functions should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20111004232958.GA21205@quack.suse.cz>
Date:	Wed, 5 Oct 2011 01:29:58 +0200
From:	Jan Kara <jack@...e.cz>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-ext4@...r.kernel.org, jack@...e.cz,
	akpm@...ux-foundation.org, adilger.kernel@...ger.ca
Subject: Re: [PATCH] ext3/balloc.c: local functions should be static

On Fri 23-09-11 13:55:52, H Hartley Sweeten wrote:
> This quites the sparse noise:
> 
> warning: symbol 'ext3_trim_all_free' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@...ger.ca>
  Thanks, merged into my tree.

								Honza
> 
> ---
> 
> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
> index 6386d76..8e62ec5 100644
> --- a/fs/ext3/balloc.c
> +++ b/fs/ext3/balloc.c
> @@ -1924,9 +1924,10 @@ unsigned long ext3_bg_num_gdb(struct super_block *sb, int group)
>   * reaches any used block. Then issue a TRIM command on this extent and free
>   * the extent in the block bitmap. This is done until whole group is scanned.
>   */
> -ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, unsigned int group,
> -				ext3_grpblk_t start, ext3_grpblk_t max,
> -				ext3_grpblk_t minblocks)
> +static ext3_grpblk_t ext3_trim_all_free(struct super_block *sb,
> +					unsigned int group,
> +					ext3_grpblk_t start, ext3_grpblk_t max,
> +					ext3_grpblk_t minblocks)
>  {
>  	handle_t *handle;
>  	ext3_grpblk_t next, free_blocks, bit, freed, count = 0;
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html