linux-ext4 - Re: [PATCH] ext3/xattr_seciruty.c: local functions should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111004233746.GC21205@quack.suse.cz>
Date:	Wed, 5 Oct 2011 01:37:46 +0200
From:	Jan Kara <jack@...e.cz>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-ext4@...r.kernel.org, jack@...e.cz,
	akpm@...ux-foundation.org, adilger.kernel@...ger.ca
Subject: Re: [PATCH] ext3/xattr_seciruty.c: local functions should be static

On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
> Quiets the sparse noise:
> 
> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Jan Kara <jack@...e.cz>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@...ger.ca>
  Here applies the same comment as to the ext2 patch - not in current
Linus' kernel AFAICS.

								Honza
> 
> ---
> 
> diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
> index 3c218b8..3f065f8 100644
> --- a/fs/ext3/xattr_security.c
> +++ b/fs/ext3/xattr_security.c
> @@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
>  			      name, value, size, flags);
>  }
>  
> -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
>  		    void *fs_info)
>  {
>  	const struct xattr *xattr;
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html