linux-ext4 - Re: [PATCH 4/6] ext4: remove messy logic from ext4_ext_rm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111025114406.GE31921@thunk.org>
Date:	Tue, 25 Oct 2011 07:44:06 -0400
From:	Ted Ts'o <tytso@....edu>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-ext4@...r.kernel.org, achender@...ux.vnet.ibm.com
Subject: Re: [PATCH 4/6] ext4: remove messy logic from ext4_ext_rm_leaf

On Fri, Oct 21, 2011 at 01:08:57AM +0400, Dmitry Monakhov wrote:
> - Both callers(truncate and punch_hole) already aligned left end point
>   so we no longer need split logic here.
> - Remove dead duplicated code.
> - Call ext4_ext_dirty only after we have updated eh_entries, otherwise
>   we'll loose entries update. Regression caused by d583fb87a3ff0
>   266'th testcase in xfstests (http://patchwork.ozlabs.org/patch/120872)
> 
> Signed-off-by: Dmitry Monakhov <dmonakhov@...nvz.org>

Thanks, applied

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html