[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120104074357.GC17026@dastard>
Date: Wed, 4 Jan 2012 18:43:57 +1100
From: Dave Chinner <david@...morbit.com>
To: Ted Ts'o <tytso@....edu>
Cc: Thomas Lindroth <thomas.lindroth@...il.com>,
linux-ext4@...r.kernel.org
Subject: Re: e4defrag modifies folder's mtime.
On Wed, Jan 04, 2012 at 12:27:18AM -0500, Ted Ts'o wrote:
> On Wed, Jan 04, 2012 at 03:53:18PM +1100, Dave Chinner wrote:
> >
> > xfs_fsr doesn't use these donor files to avoid mtime updates - it
> > uses invisible IO (i.e. O_NOATIME|O_NOCMTIME) to do that.
>
> O_NOCMTIME doesn't exist yet. From include/linux/fs.h:
>
> /*
> * Don't update ctime and mtime.
> *
> * Currently a special hack for the XFS open_by_handle ioctl, but we'll
> * hopefully graduate it to a proper O_CMTIME flag supported by open(2) soon.
> */
> #define FMODE_NOCMTIME ((__force fmode_t)0x800)
>
> I'd have to check, but it wouldn't surprise me if glibc is filtering
> out all fcntl flags it doesn't understand, so for now, this is an
> XFS-only special...
Sounds to me like e2defrag needs it, so perhaps it should finally
be made a proper open flag like the comment says rather than
inventing some other way of solving the problem....
Cheers,
Dave.
--
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists