linux-ext4 - Re: [PATCH] mke2fs: correct help text for option -G of mke2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGBYx2Yc+NnEMw1rNAbH-GNq6xZ+ZJ8Z7iYBqoWc+7Cas6eD4g@mail.gmail.com>
Date:	Wed, 4 Jan 2012 15:47:31 +0800
From:	Yongqiang Yang <xiaoqiangnk@...il.com>
To:	Andreas Dilger <aedilger@...il.com>
Cc:	"tytso@....edu" <tytso@....edu>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] mke2fs: correct help text for option -G of mke2fs

On Wed, Jan 4, 2012 at 3:22 PM, Andreas Dilger <aedilger@...il.com> wrote:
> Probably "flex_group_size" or "flex_group_factor" is as clear and a lot shorter.
I will resend a patch using flex_group_factor.

Thanks,
Yongqiang.
>
> Cheers, Andreas
>
> On 2012-01-03, at 20:29, Yongqiang Yang <xiaoqiangnk@...il.com> wrote:
>
>> The option '-G' is used to pass number of groups in a flex_bg, the
>> previous help text - 'meta-group-size' - could confuse users with
>> meta_bg.
>>
>> Signed-off-by: Yongqiang Yang <xiaoqiangnk@...il.com>
>> ---
>> misc/mke2fs.c |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
>> index 0ef2531..52746fe 100644
>> --- a/misc/mke2fs.c
>> +++ b/misc/mke2fs.c
>> @@ -116,7 +116,7 @@ static void usage(void)
>>    fprintf(stderr, _("Usage: %s [-c|-l filename] [-b block-size] "
>>    "[-C cluster-size]\n\t[-i bytes-per-inode] [-I inode-size] "
>>    "[-J journal-options]\n"
>> -    "\t[-G meta group size] [-N number-of-inodes]\n"
>> +    "\t[-G number-of-groups-per-flex_bg] [-N number-of-inodes]\n"
>>    "\t[-m reserved-blocks-percentage] [-o creator-os]\n"
>>    "\t[-g blocks-per-group] [-L volume-label] "
>>    "[-M last-mounted-directory]\n\t[-O feature[,...]] "
>> --
>> 1.7.5.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Best Wishes
Yongqiang Yang
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html