linux-ext4 - Re: [PATCH 08/54] e2fsck: Verify and correct inode checksums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120310050928.GC5652@thunk.org>
Date:	Sat, 10 Mar 2012 00:09:28 -0500
From:	Ted Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <djwong@...ibm.com>
Cc:	Andreas Dilger <adilger.kernel@...ger.ca>,
	Sunil Mushran <sunil.mushran@...cle.com>,
	Amir Goldstein <amir73il@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Mingming Cao <cmm@...ibm.com>,
	Joel Becker <jlbec@...lplan.org>, linux-ext4@...r.kernel.org,
	Coly Li <colyli@...il.com>
Subject: Re: [PATCH 08/54] e2fsck: Verify and correct inode checksums

On Tue, Mar 06, 2012 at 03:58:12PM -0800, Darrick J. Wong wrote:
> Detect mismatches of the inode and checksum, and prompt the user to fix the
> situation.
> 
> Signed-off-by: Darrick J. Wong <djwong@...ibm.com>

The new problem definitions were inserted into the wrong place in
problem.c.  This is something that was picked up by a unit test in the
e2fsck directory:

LD_LIBRARY_PATH=../lib DYLD_LIBRARY_PATH=../lib ./tst_problem
*** Unordered problem table:
curr code = 0x00010065: The bad @b @i looks @n.  
*** prev code = 0x00010067: @i %i passes checks, but checksum does not match @i.  
*** This is a programming error in e2fsck
make[1]: *** [check] Error 1

The fix was simple; just move the new lines in problem.c down two lines.

>  	/* Quota inode is user visible */
>  	{ PR_1_QUOTA_INODE_NOT_HIDDEN,
>  	  N_("@q @i is visible to the user.  "),
> - 	  PROMPT_CLEAR, PR_PREEN_OK },
> +	  PROMPT_FIX, PR_PREEN_OK },

PR1_QUOTA_INODE_NOT_HIDDEN isn't currently used, so there's no point
changing it now.  Depending on how this bit of the first class quota
patch gets implemented, the message might change completely.

      	   		    	    	  	 - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html