lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 20 Mar 2012 10:05:10 +0000
From:	Al Viro <>
To:	Mike Frysinger <>
Cc:	Duane Griffin <>,,
Subject: Re: umode_t breakage in exported kernel headers

On Mon, Mar 19, 2012 at 04:01:53PM -0400, Mike Frysinger wrote:
> commit 0583fcc96bb117763c0fa74c123573c0112dec65 moved umode_t out of the 
> exported headers space (via the arches' asm/types.h) and into __KERNEL__ 
> specific linux/types.h.  this breaks the exported linux/ext2_fs.h 
> ext2_mask_flags function which uses that type.  that func appears to be the 
> only one exported that utilizes umode_t.
> should ext2_mask_flags be updated to take a __kernel_mode_t as its first arg ?
> -mike

ITYM "unsigned short".  __kernel_mode_t is wrong kernel-side and pointless
everywhere.  It should *only* be used in layout of structs shared with
userland and misdefined back then.  Anything new should use explicitly-sized
types (and u16 is enough for mode).

It's nearly entirely about ncp_mount_data - ipc_perm, ipc64_perm and in
several cases st_mode of stat* are arch-dependent anyway and could bloody
well use explicitly-sized types.
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists