linux-ext4 - Re: [PATCH] ext2: cleanup the comment for ext2_export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FB19B96.4010106@gmail.com>
Date:	Tue, 15 May 2012 07:56:06 +0800
From:	Wang Sheng-Hui <shhuiw@...il.com>
To:	Jan Kara <jack@...e.cz>
CC:	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext2: cleanup the comment for ext2_export_ops

On 2012年05月14日 17:55, Jan Kara wrote:
> On Mon 14-05-12 15:15:00, Wang Sheng-Hui wrote:
>> ext2_export_ops gets more valued fields, not get_parent only.
>> Clean up the comment.
>   Um, I'd just remove the whole comment. It isn't particularly informative
> anyway - NULL meaning the default behavior is very common in kernel. And we
> really set about half of entries anyway...
> 
> 								Honza

Thanks, Honza.

Patch regenerated. Please check it.

>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@...il.com>
>> ---
>>  fs/ext2/super.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
>> index e1025c7..640b4c6 100644
>> --- a/fs/ext2/super.c
>> +++ b/fs/ext2/super.c
>> @@ -359,7 +359,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
>>  /* Yes, most of these are left as NULL!!
>>   * A NULL value implies the default, which works with ext2-like file
>>   * systems, but can be improved upon.
>> - * Currently only get_parent is required.
>>   */
>>  static const struct export_operations ext2_export_ops = {
>>  	.fh_to_dentry = ext2_fh_to_dentry,
>> -- 
>> 1.7.1

>From 362925f80bdfb1c105e346f535c5e51c7359b550 Mon Sep 17 00:00:00 2001
From: Wang Sheng-Hui <shhuiw@...il.com>
Date: Tue, 15 May 2012 07:53:46 +0800
Subject: [PATCH] ext2: remove the redundant comment for ext2_export_ops

Per Honza, It isn't particularly informative anyway - NULL
meaning the default behavior is very common in kernel. And we
really set about half of entries anyway.

Remove the whole comment for ext2_export_ops.

Signed-off-by: Wang Sheng-Hui <shhuiw@...il.com>
---
 fs/ext2/super.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index e1025c7..f9b0f41 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -356,11 +356,6 @@ static struct dentry *ext2_fh_to_parent(struct super_block *sb, struct fid *fid,
 				    ext2_nfs_get_inode);
 }
 
-/* Yes, most of these are left as NULL!!
- * A NULL value implies the default, which works with ext2-like file
- * systems, but can be improved upon.
- * Currently only get_parent is required.
- */
 static const struct export_operations ext2_export_ops = {
 	.fh_to_dentry = ext2_fh_to_dentry,
 	.fh_to_parent = ext2_fh_to_parent,
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html