[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4FBBEC83.8030604@redhat.com>
Date: Tue, 22 May 2012 14:44:03 -0500
From: Eric Sandeen <sandeen@...hat.com>
To: Zheng Liu <gnehzuil.liu@...il.com>
CC: jack@...e.cz, jouni.siren@....fi, linux-ext4@...r.kernel.org,
Zheng Liu <wenqing.lz@...bao.com>
Subject: Re: [PATCH RESEND] ext4: change return value from int to ssize_t
in ext4_file_write
On 4/12/12 8:22 PM, Zheng Liu wrote:
> On 64-platform, when we do a write operation with a huge number of data, it
> will cause that the ret variable overflows. So it is replaced with ssize_t.
>
> Reported-by: Jouni Siren <jouni.siren@....fi>
> Reviewed-by: Jan Kara <jack@...e.cz>
> Signed-off-by: Zheng Liu <wenqing.lz@...bao.com>
Ted, is this one queued anywhere? Seems lost so far.
Thanks,
-Eric
> ---
> Hi Jan,
>
> You are right. I have changed the commit log. ;-)
>
> Regards,
> Zheng
>
> fs/ext4/file.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/file.c b/fs/ext4/file.c
> index cb70f18..8c7642a 100644
> --- a/fs/ext4/file.c
> +++ b/fs/ext4/file.c
> @@ -95,7 +95,7 @@ ext4_file_write(struct kiocb *iocb, const struct iovec *iov,
> {
> struct inode *inode = iocb->ki_filp->f_path.dentry->d_inode;
> int unaligned_aio = 0;
> - int ret;
> + ssize_t ret;
>
> /*
> * If we have encountered a bitmap-format file, the size limit
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists