[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <73DE6E4C-65E5-4834-B5E2-56168DC3DBFD@whamcloud.com>
Date: Mon, 28 May 2012 17:48:53 -0600
From: Andreas Dilger <adilger@...mcloud.com>
To: Ted Ts'o <tytso@....edu>
Cc: linux-ext4@...r.kernel.org
Subject: Re: [PATCH] tests: use make rules to run tests in parallel (v2)
On 2012-05-27, at 7:18 PM, Ted Ts'o wrote:
> On Wed, May 23, 2012 at 02:09:20PM -0600, Andreas Dilger wrote:
>> Change the e2fsck/mke2fs/tune2fs/e2image/debugfs regression tests
>> to be driven by Makefile rules instead of by a script loop. This
>> allows the tests to be run in parallel like a build and reduces
>> testing time significantly.
>
> The makefile setup you've created has a fatal flaw; it completely
> blows up if you are building with VPATH. That is, try this with your
> patch: (starting with cwd in the e2fsprogs source tree)
>
> % mkdir build
> % cd build
> % ../configure
> % make
> % make check
> <boom>
>
> Could you take a look at fixing this, please? I rely pretty
> exclusively on building with VPATH (that way I can have a
> build.static, build.32, etc.) with a single source tree.
The v3 patch was fixed to work with VPATH, along with a few other
changes that I made locally while I've been using this since its
original submission.
Cheers, Andreas
--
Andreas Dilger Whamcloud, Inc.
Principal Lustre Engineer http://www.whamcloud.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists