linux-ext4 - Re: libquota: add a quotactl prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201205282037.50920.vapier@gentoo.org>
Date:	Mon, 28 May 2012 20:37:49 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Andreas Dilger <adilger@...mcloud.com>
Cc:	"Ted Ts'o" <tytso@....edu>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>
Subject: Re: libquota: add a quotactl prototype

On Monday 28 May 2012 11:31:42 Andreas Dilger wrote:
> On 2012-05-28, at 8:20, Ted Ts'o <tytso@....edu> wrote:
> > On Tue, May 22, 2012 at 09:41:29AM -0000, Mike Frysinger wrote:
> >> The commit 0df8a27bbaf51b55c0e8c3a533ef4c2ff9d79c9f removed the system
> >> quota.h include, but in doing so, added the problem:
> >> mkquota.c:55:2: warning: implicit declaration of function 'quotactl'
> >> 
> >> Since we're maintaining a copy of quota.h, add a proper func prototype.
> >> 
> >> Signed-off-by: Mike Frysinger <vapier@...too.org>
> > 
> > Thanks, applied.
> 
> This patch caused a compile failure on my FC 13 system, when I had no
> problem before, because caddr_t was not defined...

your definition of "no problem" is different from mine.  Ted's latest patch 
works fine for me though -- punt the call completely.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)