lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 9 Jul 2012 10:07:51 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	"Darrick J. Wong" <djwong@...ibm.com>
Cc:	Tao Ma <tm@....ma>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: Use proper csum calculation in ext4_rename.

On Tue, Jul 03, 2012 at 10:01:53AM -0700, Darrick J. Wong wrote:
> On Fri, Jun 22, 2012 at 11:38:34PM +0800, Tao Ma wrote:
> > From: Tao Ma <boyu.mt@...bao.com>
> > 
> > In ext4_rename, when the old name is a dir, we need to
> > change ".." to its new parent and journal the change, so
> > with metadata_csum enabled, we have to re-calc the csum.
> > 
> > As the first block of the dir can be either a htree root
> > or a normal directory block and we have different csum
> > calculation for these 2 types, we have to choose the right
> > one in ext4_rename.
> > 
> > btw, it is found by xfstests 013.
> 
> Good catch!
> 
> Acked-by: Darrick J. Wong <djwong@...ibm.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists