linux-ext4 - Re: filefrag: Fix segfault on virtual fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 28 Jul 2012 17:43:12 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>, maxnet@...inehome.de
Subject: Re: filefrag: Fix segfault on virtual fs

On Tue, Jun 26, 2012 at 03:59:08AM -0000, Eric Sandeen wrote:
> filefrag on a virtual fs like proc segfaults:
> 
> # filefrag /proc/filesystems 
> Floating point exception
> 
> because stat.f_blocks is 0, so the calculation of cylgroups is 0,
> which leads to a divide by 0 when calculating expected extents.
> 
> Since it's only used for ext2 filesystems anyway, just move
> the calculation of expected under "if (is_ext2)" to fix this.
> 
> Reported-by: Max Beikirch <maxnet@...inehome.de>
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Applied, thanks.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html