linux-ext4 - Re: [PATCH] e4defrag: Handle device symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120728215409.GH659@thunk.org>
Date:	Sat, 28 Jul 2012 17:54:09 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Kazuya Mio <k-mio@...jp.nec.com>
Subject: Re: [PATCH] e4defrag: Handle device symlinks

On Thu, Jul 19, 2012 at 02:02:30PM -0500, Eric Sandeen wrote:
> Device nodes are commonly accessed via symlinks, i.e.
> 
> # ls -l /dev/mapper/testvg-testlv 
> lrwxrwxrwx. 1 root root 7 Jul 19 13:01 /dev/mapper/testvg-testlv -> ../dm-0
> 
> Today, e4defrag on such a device will fail:
> 
> # e4defrag -c /dev/mapper/testvg-testlv 
> File is not regular file
>  "/dev/mapper/testvg-testlv"
> 
> due to it being a link, and e4defrag on the link target does as well:
> 
> # e4defrag -c /dev/dm-0 
> Filesystem is not mounted
> 
> due to the target not being found in /etc/mtab.
> 
> Fix this by checking whether the symlink target is a block device
> and if so, using that device in main(), and also changing get_mount_point()
> to search for a matching device number, not device name.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html