linux-ext4 - Re: Test 272 fails for ext3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120821080338.GA7537@quack.suse.cz>
Date:	Tue, 21 Aug 2012 10:03:39 +0200
From:	Jan Kara <jack@...e.cz>
To:	Dave Chinner <david@...morbit.com>
Cc:	Jan Kara <jack@...e.cz>, xfs@....sgi.com, dmonakhov@...nvz.org,
	linux-ext4@...r.kernel.org
Subject: Re: Test 272 fails for ext3

On Tue 21-08-12 08:49:41, Dave Chinner wrote:
> On Mon, Aug 20, 2012 at 11:06:38PM +0200, Jan Kara wrote:
> ....
> > --- a/272
> > +++ b/272
> > @@ -32,15 +32,18 @@ tmp=/tmp/$$
> >  status=1	# failure is the default!
> >  trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
> >  
> > +write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"
> > +if [ $FSTYP = "ext3" ]; then
> > +	# ext3 doesn't support direct IO in journalling mode
> > +	write_opt_list="iflag=noatime conv=notrunc conv=fsync"
> > +fi
> 
> Seems like asking for trouble duplicating the common options.
> 
> # ext3 doesn't support direct IO in journalling mode
> write_opt_list="iflag=noatime conv=notrunc conv=fsync
> [ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct"
> 
> Otherwise looks fine.
> 
> Reviewed-by: Dave Chinner <dchinner@...hat.com>
  OK, I've updated the test as you suggested. Result is attached.

								Honza

-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR

View attachment "0001-Make-test-272-work-for-ext3.patch" of type "text/x-patch" (3794 bytes)