| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120918212640.GW3274@sgi.com> Date: Tue, 18 Sep 2012 16:26:40 -0500 From: Ben Myers <bpm@....com> To: Jan Kara <jack@...e.cz> Cc: Dave Chinner <david@...morbit.com>, linux-ext4@...r.kernel.org, dmonakhov@...nvz.org, xfs@....sgi.com Subject: Re: Test 272 fails for ext3 On Tue, Aug 21, 2012 at 10:03:39AM +0200, Jan Kara wrote: > On Tue 21-08-12 08:49:41, Dave Chinner wrote: > > On Mon, Aug 20, 2012 at 11:06:38PM +0200, Jan Kara wrote: > > .... > > > --- a/272 > > > +++ b/272 > > > @@ -32,15 +32,18 @@ tmp=/tmp/$$ > > > status=1 # failure is the default! > > > trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15 > > > > > > +write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct" > > > +if [ $FSTYP = "ext3" ]; then > > > + # ext3 doesn't support direct IO in journalling mode > > > + write_opt_list="iflag=noatime conv=notrunc conv=fsync" > > > +fi > > > > Seems like asking for trouble duplicating the common options. > > > > # ext3 doesn't support direct IO in journalling mode > > write_opt_list="iflag=noatime conv=notrunc conv=fsync > > [ $FSTYP = "ext4" ] && write_opt_list="$write_opt_list oflag=direct" > > > > Otherwise looks fine. > > > > Reviewed-by: Dave Chinner <dchinner@...hat.com> > OK, I've updated the test as you suggested. Result is attached. Committed to git://oss.sgi.com/xfs/cmds/xfstests.git, master branch. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists