linux-ext4 - Re: [v2] ext4: fix possible non-initialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120922005202.GD27207@thunk.org>
Date:	Fri, 21 Sep 2012 20:52:02 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	linux-ext4@...r.kernel.org
Subject: Re: [v2] ext4: fix possible non-initialized variable

On Fri, Sep 21, 2012 at 04:14:49PM -0300, Carlos Maiolino wrote:
> Not a bad idea really.
> 
> I've found some functions properly handling the problem (i.e !bh and !err), but
> some of them not. I'm thinking in fix functions with missing hole handlers and
> after that think about a 'default directory hole handler' for this, instead of
> make each function work on a specific way.

I'd have to take a look at a patch, but I didn't think there would be
enough code to be worth factoring out into a separate function.  It's
just a conditional, a call to ext4_error(), and then setting up the
return code and releasing resources that need to be released on our
way out (which tends to be function-specific).

Am I missing something?

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html