linux-ext4 - ext4_readdir ignores filldir error code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALLzPKYO=Ccajri9Yv5OsZ=Z9X3=4n9NacqNmx4QC_Ra8yPpqQ@mail.gmail.com>
Date:	Mon, 24 Sep 2012 15:47:24 +0300
From:	"Kasatkin, Dmitry" <dmitry.kasatkin@...el.com>
To:	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	linux-ext4@...r.kernel.org, "Theodore Ts'o" <tytso@....edu>
Subject: ext4_readdir ignores filldir error code

Hello,

I noticed following in ext4_readdir() and in other file systems..

filldir returns error in "error":
       error = filldir(dirent, de->name, ...)

But function itself returns "ret"

What I can see is that when filldir fails, ext4_readir quits, but with
no error....
       while (!error && !stored && filp->f_pos < inode->i_size) {


Is it by design or an error?

- Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html