lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 24 Sep 2012 17:07:34 +0200
From:	Jan Kara <>
To:	"Kasatkin, Dmitry" <>
Cc:	"" <>,, Theodore Ts'o <>
Subject: Re: ext4_readdir ignores filldir error code


On Mon 24-09-12 15:47:24, Kasatkin, Dmitry wrote:
> I noticed following in ext4_readdir() and in other file systems..
> filldir returns error in "error":
>        error = filldir(dirent, de->name, ...)
> But function itself returns "ret"
> What I can see is that when filldir fails, ext4_readir quits, but with
> no error....
>        while (!error && !stored && filp->f_pos < inode->i_size) {
> Is it by design or an error?
  It works as designed (although I agree that the design is a bit odd).
Note that filler functions also set dirent->error which is then used by
e.g. getdents() syscall to set return value.

Jan Kara <>
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists