lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 28 Sep 2012 14:07:19 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Zheng Liu <wenqing.lz@...bao.com>
Cc:	kernel-janitors@...r.kernel.org, Theodore Ts'o <tytso@....edu>,
	linux-ext4@...r.kernel.org
Subject: [ext4:dev 47/50] fs/ext4/indirect.c:1799 ext4_ind_punch_hole() warn:
 inconsistent returns mutex:&inode->i_mutex: locked (1710) unlocked (1799)

Hi Zheng,

FYI, there are new smatch warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
head:   b2f1a8e5612e2488a3995ec06b422b44651d088b
commit: 3e1b02687146ddefa8e53c2a5e13d3bd87b16b09 [47/50] ext4: add support for hole punching non-extent-mapped files

+ fs/ext4/indirect.c:1799 ext4_ind_punch_hole() warn: inconsistent returns mutex:&inode->i_mutex: locked (1710) unlocked (1799)

vim +1799 fs/ext4/indirect.c

3e1b0268 (Zheng Liu      2012-09-28  1783) 	down_write(&EXT4_I(inode)->i_data_sem);
3e1b0268 (Zheng Liu      2012-09-28  1784) 	ext4_discard_preallocations(inode);
3e1b0268 (Zheng Liu      2012-09-28  1785) 
3e1b0268 (Zheng Liu      2012-09-28  1786) 	err = ext4_free_hole_blocks(handle, inode, offsets1, n1, offsets2, n2);
3e1b0268 (Zheng Liu      2012-09-28  1787) 
3e1b0268 (Zheng Liu      2012-09-28  1788) 	if (IS_SYNC(inode))
3e1b0268 (Zheng Liu      2012-09-28  1789) 		ext4_handle_sync(handle);
3e1b0268 (Zheng Liu      2012-09-28  1790) 
3e1b0268 (Zheng Liu      2012-09-28  1791) 	up_write(&EXT4_I(inode)->i_data_sem);
3e1b0268 (Zheng Liu      2012-09-28  1792) 
3e1b0268 (Zheng Liu      2012-09-28  1793) out:
3e1b0268 (Zheng Liu      2012-09-28  1794) 	inode->i_mtime = inode->i_ctime = ext4_current_time(inode);
3e1b0268 (Zheng Liu      2012-09-28  1795) 	ext4_mark_inode_dirty(handle, inode);
3e1b0268 (Zheng Liu      2012-09-28  1796) 	ext4_journal_stop(handle);
3e1b0268 (Zheng Liu      2012-09-28  1797) error:
3e1b0268 (Zheng Liu      2012-09-28  1798) 	mutex_unlock(&inode->i_mutex);
3e1b0268 (Zheng Liu      2012-09-28 @1799) 	return err;
3e1b0268 (Zheng Liu      2012-09-28  1800) }

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists