linux-ext4 - Re: [PATCH] ext4: fix ext4_flush_completed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121005042059.GC11723@thunk.org>
Date:	Fri, 5 Oct 2012 00:20:59 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Jan Kara <jack@...e.cz>
Cc:	Dmitry Monakhov <dmonakhov@...nvz.org>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix ext4_flush_completed_IO wait semantics

On Thu, Oct 04, 2012 at 12:11:06PM +0200, Jan Kara wrote:
> >  retry:
> >  	if (rw == READ && ext4_should_dioread_nolock(inode)) {
> > -		if (unlikely(!list_empty(&ei->i_completed_io_list)))
> > -			ext4_flush_completed_IO(inode);
> > -
> > +		if (unlikely(!atomic_read(&EXT4_I(inode)->i_unwritten))) {
>   This condition which seems to be inverted...

Nice catch, thanks!  I've fixed this in my tree.

     	    	   	      	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html