lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121119162211.GA2337@gmail.com> Date: Tue, 20 Nov 2012 00:22:11 +0800 From: Zheng Liu <gnehzuil.liu@...il.com> To: Theodore Ts'o <tytso@....edu> Cc: Sachin Kamat <sachin.kamat@...aro.org>, linux-ext4@...r.kernel.org, adilger.kernel@...ger.ca, patches@...aro.org Subject: Re: [PATCH 1/1] ext4: Remove duplicate inclusion of ext4_extents.h in super.c On Mon, Nov 19, 2012 at 10:00:00AM -0500, Theodore Ts'o wrote: > On Mon, Nov 19, 2012 at 09:39:45PM +0800, Zheng Liu wrote: > > Hi Sachin, > > > > Sorry, I don't find this duplicated code in mainline kernel 3.7-rc6. > > It's there because ext4.h includes ext4_extents.h -- at the end of the > header file, where it's not quite as obvious. Ah, I see. Thanks for pointing out. > > What we should probably do is move the function declarations into > ext4.h, and then see if we can isolate the number of fs/ext4/*.c files > that are aware of the on-disk extents encoding, such that it doesn't > make sense to #include ext4_extenst.h from the ext4.h header file. > > It's mainly a cleanup thing, but it would probably also help if we > ever want to support alternate extents encodings (for example to > support a full 64-bit physical block numbers, or more likely, more > than 32 bits worth of logical block nunbers --- so we can test large > file systems natively using ext4, instead of using xfs, which is what > I currently do). That's a low priority thing in my book, but if > someone is interesting in taking on the project, they should let me > know. Cool! Thanks for sharing this information with us. Regards, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists