lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121119162356.GB2337@gmail.com> Date: Tue, 20 Nov 2012 00:23:56 +0800 From: Zheng Liu <gnehzuil.liu@...il.com> To: Sachin Kamat <sachin.kamat@...aro.org> Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, patches@...aro.org Subject: Re: [PATCH 1/1] ext4: Remove duplicate inclusion of ext4_extents.h in super.c On Mon, Nov 19, 2012 at 08:36:06PM +0530, Sachin Kamat wrote: > Hi Zheng, > > On 19 November 2012 19:09, Zheng Liu <gnehzuil.liu@...il.com> wrote: > > On Mon, Nov 19, 2012 at 04:47:22PM +0530, Sachin Kamat wrote: > >> ext4_extents.h was included twice. > >> > >> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org> > >> --- > >> fs/ext4/super.c | 1 - > >> 1 files changed, 0 insertions(+), 1 deletions(-) > >> > >> diff --git a/fs/ext4/super.c b/fs/ext4/super.c > >> index ad6cd8a..c8a6138 100644 > >> --- a/fs/ext4/super.c > >> +++ b/fs/ext4/super.c > >> @@ -50,7 +50,6 @@ > >> #include "xattr.h" > >> #include "acl.h" > >> #include "mballoc.h" > >> -#include "ext4_extents.h" > > > > Hi Sachin, > > > > Sorry, I don't find this duplicated code in mainline kernel 3.7-rc6. > > The duplicated code is available on the linux-next tree (20121115). > The second instance was added by the commit > "ext4: let ext4 maintain extent status tree" (commit id: 51865fda). Good catch. Sorry for my fault that introduces this duplicated code. The patch looks good to me. Regards, - Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists