linux-ext4 - Re: [PATCH 5/6] libext2fs: optimize rb_get_bmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121126141733.GD31891@thunk.org>
Date:	Mon, 26 Nov 2012 09:17:33 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Lukáš Czerner <lczerner@...hat.com>
Cc:	Ext4 Developers List <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 5/6] libext2fs: optimize rb_get_bmap_range() for mostly
 allocated bmaps

On Mon, Nov 26, 2012 at 12:22:42PM +0100, Lukáš Czerner wrote:
> > +		if (pos > start+num)
> 
> Missing spacing around '+'.

I'll fix all of the spacing comments, thanks.

> Also I think that the condition should rather be:
> 
> 		if (pos >= start + num)

Yes.  I believe the case where pos = start + num gets caught later on
when we check the count variable, but it's cleaner/faster to bail out
here.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html